Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer JIT compile of bulk of Program.Main #4645

Merged
merged 2 commits into from Mar 17, 2018

Conversation

drewnoakes
Copy link
Member

The JIT must load all types used in a method when the method is loaded.

Program.Main attempts to hook type initialisation exceptions via NBug.

Loading fewer types in Main increases the chance of catching such exceptions.

Other than that, there is no change to program behaviour.

What did I do to test the code and ensure quality:

  • Manual testing

Has been tested on:

  • GIT 2.16
  • Windows 10

The JIT must load all types used in a method when the method is loaded.
Main attempts to hook type initialisation exceptions via NBug.
Loading fewer types in Main increases the chance of catching such exceptions.
Other than that, there is no change to program behaviour.
@codecov
Copy link

codecov bot commented Mar 16, 2018

Codecov Report

Merging #4645 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4645   +/-   ##
=======================================
  Coverage   26.62%   26.62%           
=======================================
  Files         505      505           
  Lines       41117    41117           
  Branches     6006     6006           
=======================================
  Hits        10946    10946           
  Misses      29671    29671           
  Partials      500      500

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e3516b...1469f79. Read the comment docs.

@RussKie RussKie merged commit 68a8687 into gitextensions:master Mar 17, 2018
@RussKie RussKie added this to the 3.00 milestone Mar 17, 2018
@drewnoakes drewnoakes deleted the defer-main branch March 17, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants