Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GitModule.StreamCopy #4656

Merged
merged 1 commit into from Mar 17, 2018
Merged

Conversation

drewnoakes
Copy link
Member

@drewnoakes drewnoakes commented Mar 17, 2018

This method exists in the framework as Stream.CopyTo
@codecov
Copy link

codecov bot commented Mar 17, 2018

Codecov Report

Merging #4656 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4656      +/-   ##
==========================================
+ Coverage   26.68%   26.68%   +<.01%     
==========================================
  Files         501      501              
  Lines       40752    40747       -5     
  Branches     5961     5960       -1     
==========================================
  Hits        10873    10873              
+ Misses      29379    29374       -5     
  Partials      500      500
Impacted Files Coverage Δ
GitCommands/Git/GitModule.cs 8.57% <0%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9949704...be0e349. Read the comment docs.

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there were a similar change some months ago...

@drewnoakes
Copy link
Member Author

I believe there were a similar change some months ago...

Yep. Looks like it was #4343.

@RussKie RussKie added this to the 3.00 milestone Mar 17, 2018
@RussKie RussKie merged commit 9ef3e13 into gitextensions:master Mar 17, 2018
@drewnoakes drewnoakes deleted the stream-copy branch March 18, 2018 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants