Equality operators

[drewnoakes]

Changes proposed in this pull request:

• Use equality operator for comparing strings and types

The code used Equals in some places and == in others when comparing strings.

This PR makes all code use == for regular string comparison.

This doesn't effect perf but it does make the code more readable and consistent. This is C#, not Java!

What did I do to test the code and ensure quality:

• Manual review of automated refactoring
• Unit tests
• Manual testing

Has been tested on:

• GIT 2.16
• Windows 10

[codecov]

Codecov Report

Merging #4680 into master will not change coverage.
The diff coverage is 6.38%.

@@           Coverage Diff           @@
##           master    #4680   +/-   ##
=======================================
  Coverage   27.55%   27.55%           
=======================================
  Files         506      506           
  Lines       41008    41008           
  Branches     5967     5967           
=======================================
  Hits        11298    11298           
  Misses      29201    29201           
  Partials      509      509

Impacted Files	Coverage Δ
GitCommands/Settings/AppSettings.cs	26.77% <ø> (ø)	⬆️
GitUI/UserControls/PathFormatter.cs	0% <0%> (ø)	⬆️
GitCommands/Config/ConfigFile.cs	80.36% <0%> (ø)	⬆️
...mmandsDialogs/RepoHosting/DiscussionHtmlCreator.cs	0% <0%> (ø)	⬆️
...tingsDialog/Pages/GitConfigAdvancedSettingsPage.cs	38.46% <0%> (ø)	⬆️
...BrowseDialog/DashboardControl/DashboardCategory.cs	17.75% <0%> (ø)	⬆️
...rols/RevisionGridClasses/GitRefListsForRevision.cs	0% <0%> (ø)	⬆️
...mmandsDialogs/RepoHosting/CreatePullRequestForm.cs	13.23% <0%> (ø)	⬆️
ResourceManager/Translator.cs	28.2% <0%> (ø)	⬆️
GitUI/CommandsDialogs/FormCheckoutBranch.cs	19.85% <0%> (ø)	⬆️
... and 17 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a01c280...339763b. Read the comment docs.