Replace tail call recursion with loop #4681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4681 +/- ##
==========================================
+ Coverage 28.23% 28.23% +<.01%
==========================================
Files 511 511
Lines 41082 41081 -1
Branches 5938 5938
==========================================
Hits 11598 11598
+ Misses 28966 28965 -1
Partials 518 518
Continue to review full report at Codecov.
|
RussKie
reviewed
Mar 20, 2018
GitUI/Plugin/LoadPlugins.cs
Outdated
| if (arg.InnerException != null) | ||
| exceptionInfo += e.Message + "\r\n"; | ||
|
|
||
| if (e.InnerException != null) |
There was a problem hiding this comment.
I would invert it to increase readability
gerhardol
approved these changes
Mar 20, 2018
drewnoakes
force-pushed
the
iteration
branch
4 times, most recently
from
088b18b
to
889e773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
What did I do to test the code and ensure quality:
Has been tested on: