Multiple enumeration #4682
Merged
Multiple enumeration #4682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4682 +/- ##
==========================================
- Coverage 27.57% 27.55% -0.02%
==========================================
Files 508 508
Lines 40989 40992 +3
Branches 5965 5977 +12
==========================================
- Hits 11301 11296 -5
- Misses 29179 29185 +6
- Partials 509 511 +2
Continue to review full report at Codecov.
|
RussKie
approved these changes
Mar 20, 2018
If implementation of IEnumerable<T> also implements ICollection<T> or ICollection, then the corresponding Count property can be used directly, avoiding enumeration.
drewnoakes
force-pushed
the
multiple-enumeration
branch
from
5b71372
to
8511b13
Compare
Removed most occurrences of IList. Remaining ones cannot easily be removed.
The values were cached, but in a presentation that didn't suit their usage. This change stores them at the type they need to be. Nest methods.
|
Went through and addressed most of the remaining |
gerhardol
approved these changes
Mar 22, 2018
| IList<GitRevision> items = new List<GitRevision> { _headRevision, baseCommit }; | ||
| var items = new List<GitRevision> { _headRevision, baseCommit }; | ||
|
|
||
| // TODO this can never be true |
There was a problem hiding this comment.
Remove this in separate commit?
| @@ -69,6 +65,53 @@ public void Initialize(bool remote, string[] containRevisons) | |||
| { | |||
| Branches.Text = null; | |||
| } | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
IReadOnlyList<T>across all ofGitModuleand places that then must change in response to thatAs mentioned elsewhere, this PR explores broader use of
IReadOnlyList<T>. Currently quite a lot of data is passed around as the modifiableIList<T>which makes sense given GE has been around for longer than the comparatively newIReadOnlyList<T>. HoweverIList<T>leaves you wondering, is it safe to modify this collection?Before this PR there were 140 instances of
"IList<"betweenGitCommandsandGitUIprojects. After, there are 56.Interested in thoughts on this direction before going after the last instances.
What did I do to test the code and ensure quality:
Has been tested on: