New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing word to dialog text #4695
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4695 +/- ##
======================================
Coverage 27.6% 27.6%
======================================
Files 508 508
Lines 40856 40856
Branches 5955 5955
======================================
Hits 11278 11278
Misses 29068 29068
Partials 510 510
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translation app will update .xlf files when run.
For some strings you will not see the updated translation until English.xlf is updated too
Thanks for the detail @gerhardol. |
To expand on Gerhard's answer, have a look at how we update translations - https://github.com/gitextensions/gitextensions/wiki/How-To:-prepare-a-release#2-preparing-to-release |
@RussKie is this an example where you'd be happy for me to merge? |
Yes
…On 28 March 2018 at 20:45, Drew Noakes ***@***.***> wrote:
@RussKie <https://github.com/RussKie> is this an example where you'd be
happy for me to merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4695 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEMyXt6QvRwKo2IuJfJNmkcvMJ305le7ks5ti1u1gaJpZM4S4qgV>
.
|
Fixes the missing word observed in #4691.
QUESTION: Does the translation system rely on this string? Does this change require something more for translation to continue to work? I took a look through the code and decided it didn't, but it'd be good to confirm.