Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing word to dialog text #4695

Merged
merged 1 commit into from Mar 28, 2018

Conversation

drewnoakes
Copy link
Member

Fixes the missing word observed in #4691.

image

QUESTION: Does the translation system rely on this string? Does this change require something more for translation to continue to work? I took a look through the code and decided it didn't, but it'd be good to confirm.

@codecov
Copy link

codecov bot commented Mar 23, 2018

Codecov Report

Merging #4695 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4695   +/-   ##
======================================
  Coverage    27.6%   27.6%           
======================================
  Files         508     508           
  Lines       40856   40856           
  Branches     5955    5955           
======================================
  Hits        11278   11278           
  Misses      29068   29068           
  Partials      510     510
Impacted Files Coverage Δ
GitUI/CommandsDialogs/FormCommit.cs 9.03% <100%> (ø) ⬆️
GitUI/CommandsDialogs/RevisionDiff.cs 4.73% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a7c7a...a521d52. Read the comment docs.

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation app will update .xlf files when run.
For some strings you will not see the updated translation until English.xlf is updated too

@drewnoakes
Copy link
Member Author

Thanks for the detail @gerhardol.

@RussKie
Copy link
Member

RussKie commented Mar 24, 2018

To expand on Gerhard's answer, have a look at how we update translations - https://github.com/gitextensions/gitextensions/wiki/How-To:-prepare-a-release#2-preparing-to-release

@RussKie RussKie added this to the 3.00 milestone Mar 24, 2018
@drewnoakes
Copy link
Member Author

@RussKie is this an example where you'd be happy for me to merge?

@RussKie
Copy link
Member

RussKie commented Mar 28, 2018 via email

@drewnoakes drewnoakes merged commit f52ce5c into gitextensions:master Mar 28, 2018
@drewnoakes drewnoakes deleted the dialog-text-4691 branch March 28, 2018 10:43
@drewnoakes drewnoakes changed the title Add missing word to dialog text (#4691) Add missing word to dialog text Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants