Get remotes #4705
Merged
Get remotes #4705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## master #4705 +/- ##
=======================================
Coverage 28.23% 28.23%
=======================================
Files 511 511
Lines 41082 41082
Branches 5938 5938
=======================================
Hits 11598 11598
Misses 28966 28966
Partials 518 518
Continue to review full report at Codecov.
|
RussKie
reviewed
Mar 25, 2018
| @@ -294,7 +294,7 @@ private void PopulateRemotes(List<GitRemote> allRemotes, bool enabled) | |||
| Func<string[]> func; | |||
| if (enabled) | |||
| { | |||
| func = module.GetRemotes; | |||
| func = () => module.GetRemotes(); | |||
There was a problem hiding this comment.
Aren't they functionally equivalent?
There was a problem hiding this comment.
Functionally yes, but the old code wouldn't compile after the change to GetRemotes to use a default argument. Now there's no actual method with zero arguments. The new code calls a method with one argument, and the compiler pops in the default value at the call site automatically.
If we get rid of that argument as I'm thinking makes sense, we'll be able to revert this line.
RussKie
approved these changes
Mar 25, 2018
|
Ah, cool. Makes sense. Some things a bit hard to appreciate by just looking
at a webpage.
…On 25 March 2018 at 20:23, Drew Noakes ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In GitCommands/Remote/GitRemoteManager.cs
<#4705 (comment)>
:
> @@ -294,7 +294,7 @@ private void PopulateRemotes(List<GitRemote> allRemotes, bool enabled)
Func<string[]> func;
if (enabled)
{
- func = module.GetRemotes;
+ func = () => module.GetRemotes();
Functionally yes, but the old code wouldn't compile after the change to
GetRemotes to use a default argument. Now there's no actual method with
zero arguments. The new code calls a method with one argument, and the
compiler pops in the default value at the call site automatically.
If we get rid of that argument as I'm thinking makes sense, we'll be able
to revert this line.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4705 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEMyXossJUVIImLtIvlyESyS-emL-R_vks5th2IKgaJpZM4S6ECe>
.
|
The 'allowEmpty' parameter of GitModule.GetRemotes looks suspicious. This method will always return an empty string at the end if it's true (which is the default). Removing this parameter will require some study into possible impact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Has been tested on: