Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review GitModule.GetSelectedBranchFast #4707

Merged

Conversation

drewnoakes
Copy link
Member

Changes proposed in this pull request:

  • Document what's going on.
  • Do fewer string allocations.

What did I do to test the code and ensure quality:

  • Manual testing

Has been tested on:

  • GIT 2.16
  • Windows 10

@drewnoakes drewnoakes mentioned this pull request Mar 25, 2018
@codecov
Copy link

codecov bot commented Mar 25, 2018

Codecov Report

Merging #4707 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #4707   +/-   ##
=======================================
  Coverage   28.23%   28.23%           
=======================================
  Files         511      511           
  Lines       41082    41082           
  Branches     5938     5938           
=======================================
  Hits        11598    11598           
  Misses      28966    28966           
  Partials      518      518
Impacted Files Coverage Δ
GitCommands/Git/GitModule.cs 8.83% <0%> (-0.01%) ⬇️
GitUI/Plugin/LoadPlugins.cs 0% <0%> (ø) ⬆️
GitUI/GitUIExtensions.cs 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d0c04...e3f3ec3. Read the comment docs.

@RussKie RussKie added this to the 3.00 milestone Mar 25, 2018
@RussKie RussKie added the ready label Mar 25, 2018
Document what's going on.
Do fewer string allocations.
@drewnoakes drewnoakes merged commit a57c6b2 into gitextensions:master Mar 28, 2018
@drewnoakes drewnoakes deleted the get-selected-branch-fast branch March 28, 2018 09:07
@drewnoakes drewnoakes removed the ready label Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants