Fix separator in file name within File History form

[lanfeust69]

Following generalization of use of IFullPathResolver, the separator used in the
File History form ends up as the native one, while it should be the posix '/'
for later git commands to work properly (via right-click command for instance).

[drewnoakes]

If the goal is to have the FileName property be a proper POSIX path then perhaps the conversion should be done on line 203 where the property is assigned. The path can be sourced from multiple paths, and at this point this PR only addresses one of them.

What do you think?

[drewnoakes]

I see the fileName local is used below (eg. line 220), so it's not enough to just call ToPosixPath on the assignment. Instead maybe insert fileName = fileName.ToPosixPath() on line 202.

[drewnoakes]

The bug this PR fixes causes file histories to not work across renames, even when the option for this behaviour is requested.

[lanfeust69]

I tried to fix the regression introduced here in a minimalist fashion :

• the local fileName is supposed to be posix-formatted per comment on line 148
• this is no longer true at the one place where fileName depends on fullFilePath, line 195
• so fix line 195

The alternative would be to move the lines 173-176 to line 202, possibly slightly better...

BTW, I checked that fullFilePath is not used elsewhere in a way were it being a native path could cause problem.

[drewnoakes]

Looks good. Thanks!

[RussKie]

@lanfeust69 could you please the same fix to 2.51 branch?

[lanfeust69]

@RussKie : the bug shouldn't happen in 2.51, which doesn't include 66db699. Or am I misreading the history ?

[RussKie]

Ahh good. Thanks for confirming it.

…

On 9 April 2018 at 03:33, Jean-Jacques Lafay ***@***.***> wrote: @RussKie <https://github.com/RussKie> : the bug shouldn't happen in 2.51, which doesn't include 66db699 <66db699>. Or am I misreading the history ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4770 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEMyXpDs88dGTQ9vstvAGns0EFeYTcHCks5tmkntgaJpZM4TGgOR> .