New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix filter commit label #4926
Fix filter commit label #4926
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4926 +/- ##
==========================================
+ Coverage 34.52% 34.52% +<.01%
==========================================
Files 542 542
Lines 43154 43154
Branches 5967 5967
==========================================
+ Hits 14897 14899 +2
+ Misses 27522 27520 -2
Partials 735 735 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest change to SHA in text, otherwise OK
GitUI/FilterRevisionsHelper.cs
Outdated
_commitFilterToolStripMenuItem.Checked = true; | ||
_commitFilterToolStripMenuItem.CheckOnClick = true; | ||
_commitFilterToolStripMenuItem.Name = "commitToolStripMenuItem1"; | ||
_commitFilterToolStripMenuItem.Text = "Commit message and Sha1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHA-1 (and SHA) is used in similar commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 I would actually use 'hash' instead of 'SHA'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've heard some people use "commish" for "commit hash".
Either way we need to be consistent, and if we currently use SHA and SHA-1 then we need to continue with this.
We can reword it to "hash" or "commit hash" (or even "commish") separately before v3 is released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They surely use "commitish" ;-) but that is larger than just "commit hash" and refer to everything that end up pointing to a commit.
So, I think it is not understandable by most and also not exactly what we filter here (except if I'm wrong).
I like "hash" (or "SHA") which are more future proof :-)
I will update to "SHA" if that's we use at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally, I have choosen "hash" because that's what is used in the commit details tab and in the "copy to clipboard" menu.
7d7ed4b
to
f0cb3f0
Compare
f0cb3f0
to
a778306
Compare
Changes proposed in this pull request:
Screenshots before and after (if PR changes UI):