Add two patterns to C# AutoCompleteRegexes #5285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds auto-complete/dictionary entries for the commit message text box based on `new` and `using` patterns. As an example, in a recent commit message: > Use ArgumentBuilder and move SmartFormat reference Before this change, both ArgumentBuilder and SmartFormat were flagged as spelling mistakes. These symbols were present in code resembling `new ArgumentBuilder` and `using SmartFormat;`.
Codecov Report
@@ Coverage Diff @@
## master #5285 +/- ##
==========================================
+ Coverage 36.03% 36.03% +<.01%
==========================================
Files 590 590
Lines 45256 45256
Branches 6224 6224
==========================================
+ Hits 16309 16310 +1
+ Misses 28196 28195 -1
Partials 751 751 |
RussKie
approved these changes
Aug 4, 2018
|
We will need to write some serious tests around those arcane regex's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds auto-complete/dictionary entries for the commit message text box based on
newandusingpatterns.As an example, in a recent commit message:
Before this change, both ArgumentBuilder and SmartFormat were flagged as spelling mistakes. These symbols were present in code resembling
new ArgumentBuilderandusing SmartFormat;.Has been tested on (remove any that don't apply):