Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused branches one at the time. #5533

Merged
merged 1 commit into from Oct 7, 2018
Merged

Conversation

spdr870
Copy link
Member

@spdr870 spdr870 commented Oct 7, 2018

Deleting branches one at the time is slower, but sometimes a branch cannot be deleted for some reason. The entire process will then stop. Since there is no proper error handling showing what went wrong, this makes the plugin unusable.

Changes proposed in this pull request:

  • Delete branches 1 at the time instead of 1 command.
  • I expect this plugin to be used occasionally. That the performance is not top-notch is ok. I use this once every 6 months, to clean up not-deleted feature branches. Usually I delete ~1500 branches in 1 batch.

What did I do to test the code and ensure quality:

  • I used the plugin. Before, the process stopped. I needed to debug the code to see what went wrong.

Could it be improved?

  • It would be nice if there is some kind of progress indicator
  • It would be nice to see what went wrong, if a branch could not be deleted

Has been tested on (remove any that don't apply):

  • GIT 2.19
  • Windows 10

It is slower, but sometimes a branch cannot be deleted for some reason. The entire process will then stop.
@RussKie RussKie added this to the 3.00-beta2 milestone Oct 7, 2018
@vbjay
Copy link
Contributor

vbjay commented Oct 7, 2018 via email

@spdr870 spdr870 merged commit 4415db8 into master Oct 7, 2018
@RussKie RussKie deleted the feature/deleteobsolate branch December 17, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants