Fixed null reference when hovering over lane in graph #5724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
RussKie
reviewed
Nov 7, 2018
| @@ -505,7 +505,7 @@ string GetLaneInfo(int x, int rowIndex) | |||
| if (segmentsForLane.Count() == 1) | |||
| { | |||
| // Crossing lange | |||
| laneInfoText.Append(segmentsForLane.First().Parent.GitRevision.Body ?? segmentsForLane.First().Parent.GitRevision.Subject); | |||
| laneInfoText.Append(segmentsForLane.First().Parent.GitRevision?.Body ?? segmentsForLane.First().Parent.GitRevision?.Subject); | |||
There was a problem hiding this comment.
No, a segment only exists with both a parent and a child.
RussKie
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes null reference when hovering over a lane that continues beyond the limit of the graph. For example, see the screenprint below. The linux repo has over 600.000 commits. Its limited by default on 100.000 commits. Go to the last commit and hover over the lanes in the graph. A null reference is thrown. The application doesn't crash, the exception is eaten somewhere. Still, its better to prevent.
Changes proposed in this pull request:
What did I do to test the code and ensure quality:
Has been tested on (remove any that don't apply):