Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditNetSpell: Double click marks the whole word (including underscores) #5725

Conversation

mstv
Copy link
Member

@mstv mstv commented Nov 7, 2018

Changes proposed in this pull request:

  • EditNetSpell, which is used e.g. for entering the commit message, marks the whole word (including underscores) on double click.

Screenshots before and after (if PR changes UI):

  • before/after:
    grafik grafik
    grafik grafik
    grafik grafik
    grafik grafik

What did I do to test the code and ensure quality:

  • added test cases

Has been tested on (remove any that don't apply):

  • Git Extensions 3.00.a1
  • 9fe5824
  • Git 2.19.1.windows.1
  • Microsoft Windows NT 6.1.7601 Service Pack 1
  • .NET Framework 4.7.2117.0

@codecov
Copy link

codecov bot commented Nov 7, 2018

Codecov Report

Merging #5725 into master will increase coverage by 0.02%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master    #5725      +/-   ##
==========================================
+ Coverage   36.58%   36.61%   +0.02%     
==========================================
  Files         613      613              
  Lines       47134    47156      +22     
  Branches     6297     6298       +1     
==========================================
+ Hits        17245    17264      +19     
- Misses      29106    29110       +4     
+ Partials      783      782       -1

@RussKie
Copy link
Member

RussKie commented Nov 7, 2018

What about -?

@mstv
Copy link
Member Author

mstv commented Nov 7, 2018

- is a delimiter as before:

grafik

How should it be handled in your opinion?

@RussKie
Copy link
Member

RussKie commented Nov 7, 2018 via email

GitUI/SpellChecker/WordAtCursorExtractor.cs Outdated Show resolved Hide resolved
GitUI/SpellChecker/WordAtCursorExtractor.cs Outdated Show resolved Hide resolved
GitUI/SpellChecker/WordAtCursorExtractor.cs Show resolved Hide resolved
GitUI/SpellChecker/WordAtCursorExtractor.cs Outdated Show resolved Hide resolved
GitUI/SpellChecker/WordAtCursorExtractor.cs Outdated Show resolved Hide resolved
@mstv mstv force-pushed the feature/dont_stop_marking_words_at_underscore branch from 9fe5824 to 562dc4d Compare November 8, 2018 21:10
@RussKie RussKie modified the milestones: 3.0.1, 3.00 Nov 9, 2018
@RussKie RussKie merged commit a25d4f0 into gitextensions:master Nov 11, 2018
@mstv mstv deleted the feature/dont_stop_marking_words_at_underscore branch November 13, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants