Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 5353: scrolling issue caused by refreshing the objecttree #5727

Merged
merged 1 commit into from Nov 9, 2018

Conversation

spdr870
Copy link
Member

@spdr870 spdr870 commented Nov 8, 2018

Fixes #5353
Fixes #5726

Changes proposed in this pull request:

  • There is already a mechanism to ignore selectionchange events. Reused this mechanism.
  • Extend the section where selectionchanged events are ignored.

What did I do to test the code and ensure quality:

  • Manual testing

Has been tested on (remove any that don't apply):

  • GIT 2.19
  • Windows 10

@ghost ghost assigned spdr870 Nov 8, 2018
@ghost ghost added the status: ready label Nov 8, 2018
@codecov
Copy link

codecov bot commented Nov 8, 2018

Codecov Report

Merging #5727 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5727      +/-   ##
==========================================
+ Coverage   36.58%   36.58%   +<.01%     
==========================================
  Files         613      613              
  Lines       47134    47134              
  Branches     6297     6297              
==========================================
+ Hits        17245    17246       +1     
  Misses      29106    29106              
+ Partials      783      782       -1

@spdr870 spdr870 added this to the 3.00 milestone Nov 8, 2018
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Viewed in a browser. Looks sensible.

@spdr870 spdr870 merged commit 3559361 into gitextensions:master Nov 9, 2018
@ghost ghost removed the status: ready label Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants