Issue 4885 - Integration of PluginManager

[maraf]

This pull integrates download and inclusion of a latest PluginManager from its releases in GitHub repository.

Downloaded content is stored in Plugins\GitExtensions.PluginManager and is excluded from git.
New download is executed only when a new PluginManager release is found.
HeatDirectory build task is used for integration into Setup.wixproj.

[maraf]

@RussKie Is Prepare-Release.ps1 used in AppVeyor build? I have placed download there...

[RussKie]

Prepare-Release.ps1 used in AppVeyor build? I have placed download there...

It is the right place. The script is currently run manually whenever a release is prepared.
There is a plan to fully automate this, but time is an issue right now.

[RussKie]

Very nice!

I'd like to change the default NuGet source to be nuget.org. Myget is commercial, and I would expect the majority of plugins published to a free service (such as nuget.org).

[RussKie]

The build is failing - https://ci.appveyor.com/project/gitextensions/gitextensions/builds/20304184/messages
I think we need to check in an empty folder with .gitignore, so the setup project can build.

[vbjay]

The standard is to use a .gitkeep file with optional why the file is there. Just a text file.

…

On Wed, Nov 14, 2018, 8:33 PM RussKie ***@***.***> wrote: The build is failing - https://ci.appveyor.com/project/gitextensions/gitextensions/builds/20304184/messages I think we need to check in an empty folder with .gitignore, so the setup project can build. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5775 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADdhsRJrqmNUjAbcKfR548RTDdjGfkoCks5uvMRpgaJpZM4YeXCA> .

[sharwell]

Is there a link to a documented versioning strategy I can review?

[sharwell]

@RussKie I'm assuming an installer will be available without this bundled executable, correct? I'd check the AppVeyor artifacts to confirm but it's not building yet.

[maraf]

@sharwell @RussKie I can solve it either by committing empty folder with .gitkeep or I can integrate PluginManager download into Setup project build, What do you prefer?

The second option is better in handling possible future changes to PluginManager structure (additional folders or something like that).

[maraf]

@sharwell About versioning, do you mean PluginManager versioning or plugin installation requirements or anything else?

[maraf]

I have integrated PluginManager download into Setup build, so AppVeyor builds contain it.

[RussKie]

Is there a link to a documented versioning strategy I can review?

There are no documents of any kind in the department, they will need to be developed at some point in the future.
If you have any thoughts, ideas or experience to share - please do.

Few thoughts:

• the bundling of the plugin manager is an enabler to start unbundling existing plugins and allowing new plugin development
• the plugin manager versioning strategy lies with @maraf, but we're as a consumer have certainly a degree of responsibility for it
• the GE plugin API versioning strategy is absent at the moment, the plugin API has been (somewhat) stable for some time and I'll let it be for now. API versioning would likely be a breaking change, so we will need to work through this.

@maraf did raise a question about compatibility, here are my thoughts on the subject - https://github.com/maraf/GitExtensions.PluginManager/issues/36#issuecomment-427729429.

I'm assuming an installer will be available without this bundled executable, correct?

No, the plugin manager is bundled in its entirety, including the executable.
Do you see it as a problem?

[spdr870]

I would like to test this. When I run BuildInstallers.cmd, the following error appears:

If I try from Visual Studio, I get this error:

[maraf]

@spdr870 By default, Windows has disabled powershell script execution. PR executes one script, so you need enable script execution.

https://superuser.com/questions/106360/how-to-enable-execution-of-powershell-scripts

[spdr870]

I got a little further. But now I get this error. I can workaround it, but just mentioning.

Wouldn't it be a lot easier to just include the pluginmanager as a submodule and build it directly instead of having to download a binary?

[RussKie]

@spdr870 what did you do to get this error?
I run the following command:

gitextensions\Setup>powershell .\Prepare-Release.ps1 -oldVersion 2.51.05 -newVersion 3.00.00.04 -milestones '47'

Admittedly I had to further tweak our scripts (I will rework them one day), but everything downloads and bundles just fine.

[gerhardol]

Builds for me.
We need to adapt the plugin manager to debug builds (at least so it is included).
It would be good to have at least a dummy plugin online too, to see that the manager works.

[maraf]

@gerhardol I was thinking about reference GE plugin repo.
Containing empty plugin, nuget package setup etc.