Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clone dialog doesn't pick up destination #5803

Merged

Conversation

mstv
Copy link
Member

@mstv mstv commented Nov 21, 2018

Fixes #5590

Changes proposed in this pull request:

  • use the clone command's argument as destination folder unless it describes a repo

Screenshots before and after (if PR changes UI):

  • N/A

What did I do to test the code and ensure quality:

  • manual testing

Has been tested on (remove any that don't apply):

  • Windows 7

@codecov
Copy link

codecov bot commented Nov 21, 2018

Codecov Report

Merging #5803 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5803      +/-   ##
==========================================
+ Coverage   36.94%   36.95%   +0.01%     
==========================================
  Files         620      620              
  Lines       47416    47418       +2     
  Branches     6323     6324       +1     
==========================================
+ Hits        17518    17524       +6     
+ Misses      29115    29113       -2     
+ Partials      783      781       -2

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@RussKie
Copy link
Member

RussKie commented Nov 23, 2018

Thank you

@RussKie RussKie merged commit 8b43cb6 into gitextensions:master Nov 23, 2018
@ghost ghost removed the status: ready label Nov 23, 2018
@RussKie RussKie added this to the 3.00 milestone Nov 23, 2018
@mstv mstv deleted the fix/5590_clone_dialog_destination branch October 12, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants