Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement F3 to open difftool for .png #5838

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Implement F3 to open difftool for .png #5838

merged 1 commit into from
Dec 21, 2018

Conversation

mstv
Copy link
Member

@mstv mstv commented Dec 2, 2018

addendum to PR #4848 for issue #4500

Changes proposed in this pull request:

  • Commit Dialog: handle the hotkey F3 for image file (.png), too

Screenshots before and after (if PR changes UI):

  • before and after
    grafik

What did I do to test the code and ensure quality:

  • manual testing

Has been tested on (remove any that don't apply):

  • Git 2.19.1.windows.1
  • Microsoft Windows NT 6.1.7601 Service Pack 1
  • .NET Framework 4.7.2117.0

RussKie
RussKie approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed online, haven't run

@RussKie RussKie added this to the 3.0.1 milestone Dec 3, 2018
@gerhardol gerhardol modified the milestones: 3.00.01+3.01.00, 3.01.00 Dec 9, 2018
@RussKie RussKie merged commit e5878bc into gitextensions:master Dec 21, 2018
@RussKie
Copy link
Member

RussKie commented Dec 21, 2018

Thank you

@mstv mstv deleted the feature/f3_opens_difftool_for_png branch December 21, 2018 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussKie RussKie RussKie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mstv @RussKie @gerhardol