Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console tab doesn't require translation strings #5951

Merged
merged 1 commit into from Dec 20, 2018
Merged

Console tab doesn't require translation strings #5951

merged 1 commit into from Dec 20, 2018

Conversation

drewnoakes
Copy link
Member

Fixes #5916

Proposed changes

  • populate console tab after translation
  • assign console tab to own field
  • register image via standard approach

Screenshots

image

Test methodology

  • Manual testing

Test environment(s)

  • Windows 10

@drewnoakes
Console tab doesn't require translation strings
05cf7ec 
Previously, the page's caption was used to look the page up via the
tab control. This change assigns the terminal tab page to its own field
so there's never any ambiguity.

It also converts the image registration to the standard approach.

Fixes gitextensions#5916
@ghost ghost assigned drewnoakes Dec 19, 2018
@ghost ghost added the status: ready label Dec 19, 2018
@drewnoakes drewnoakes mentioned this pull request Dec 19, 2018
Closed
@drewnoakes drewnoakes added this to the 3.1.0 milestone Dec 19, 2018
@drewnoakes drewnoakes merged commit 7211073 into gitextensions:master Dec 20, 2018
@ghost ghost removed the status: ready label Dec 20, 2018
@drewnoakes drewnoakes deleted the fix-5916-console-tab-translation branch December 20, 2018 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussKie RussKie RussKie approved these changes

Assignees

@drewnoakes drewnoakes

Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewnoakes @RussKie