Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh revision grid when superproject branch/tag is completed #5981

Merged

Conversation

gerhardol
Copy link
Member

Regression, implemented as in 2.51

Fixes #5874

Proposed changes

Refresh grid when information about superproject is completed.
In 3.0 explicit refresh (e.g. selecting a revision) is required

Screenshots

Before

image

After

image

Test methodology

Manual test.
Select a subrepo and notice that the superproject branches appear after some time (without explicit UI interaction.)

Test environment(s)

@ghost ghost assigned gerhardol Dec 23, 2018
@ghost ghost added the status: ready label Dec 23, 2018
@mstv
Copy link
Member

mstv commented Dec 23, 2018

This might fix the scrambling reported in #5966.
Remain the questions: What is behind grafik? Why does it appear more often in 3.0.1 than in 3.00.00.4433?

@gerhardol
Copy link
Member Author

The first part of #5966 seem to be the same as #5874

I doubt this has something to do with second part of #5966. This triggers a redraw of the superproject references and does not affect how they look like.
There are so far no major changes in master (to be 3.1.0) compared to 3.0.0(.4333).

This should be cherry-picked to release/3.00 (next release to be 3.0.1).

Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RussKie RussKie merged commit 1c1359c into gitextensions:master Dec 29, 2018
@ghost ghost removed the status: ready label Dec 29, 2018
@gerhardol gerhardol deleted the bugfix/i5874-superproject-refs branch January 17, 2019 23:10
gerhardol pushed a commit to gerhardol/gitextensions that referenced this pull request Jan 17, 2019
…erproject-refs

Refresh revision grid when superproject branch/tag is completed

(cherry picked from commit 1c1359c)
@RussKie RussKie added this to the 3.0.1 milestone Jan 18, 2019
gerhardol pushed a commit to gerhardol/gitextensions that referenced this pull request Jan 19, 2019
…erproject-refs

Refresh revision grid when superproject branch/tag is completed

(cherry picked from commit 1c1359c)
RussKie added a commit that referenced this pull request Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants