Automatically load PuTTY SSH key files when needed in left panel

[mast-eu]

This is a follow-up of #6293 and needs to be rebased before it can be merged.

Proposed changes

• copy LoadPuttyKey() from FormPull.cs into RepoObjectsTree.cs in order to automatically load SSH keys (if available) when Update all remotes, Update and prune all remotes or Prune remote is clicked in the left panel (Move prune/prune all/update in Leftpanel remotes contextual menu #6293 adds these to the left panel context menu)

Test methodology

• manual tests
• ran unit tests

Test environment(s)

• Git Extensions 3.00.00.4433
• Git Extensions 3.1.0
• Build 5cc1e8e
• Git 2.20.1.windows.1
• Microsoft Windows NT 6.1.7601 Service Pack 1
• .NET Framework 4.7.3324.0
• DPI 120dpi (125% scaling)

---

✒️ I contribute this code under The Developer Certificate of Origin.

[codecov]

Codecov Report

Merging #6301 into master will decrease coverage by 0.01%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master    #6301      +/-   ##
==========================================
- Coverage   46.19%   46.18%   -0.02%     
==========================================
  Files         674      674              
  Lines       50790    50813      +23     
  Branches     6693     6695       +2     
==========================================
+ Hits        23464    23467       +3     
- Misses      26042    26059      +17     
- Partials     1284     1287       +3

Flag	Coverage Δ
#production	35.74% <16.66%> (-0.02%)	⬇️
#tests	97.57% <ø> (+0.03%)	⬆️

[RussKie]

Could you please rebase and fix the MC

[mast-eu]

Could you please rebase and fix the MC

done

[mast-eu]

Proposed changes

• Left panel remotes context menu: changed "Update all remotes" to "Fetch all remotes" (both text and git command); added icon (same as corresponding pull dialog shortcut)
• Left panel remotes context menu: changed "Update and prune all remotes" to "Fetch and prune all remotes" (both text and git command); added icon (same as corresponding pull dialog shortcut)
• Left panel remote context menu: changed icon for "Fetch" (same as corresponding pull dialog shortcut)
• Left panel remote context menu : changed "Prune remote" to "Fetch and prune" (both text and git command); created new icon, similar to the other ones
• all above actions now use the existing pull dialog, thus avoid code duplication and keep logic for handling SSH keys away from the left panel
• refactoring of the MessageBox "Warning! The fetch with prune will remove all the remote-tracking references which no longer exist on remotes. Do you want to proceed?", in order to show it also when pruning is triggered from the left panel (via "Fetch and prune all remotes" or "Fetch and prune")

Screenshots

Before

After

Test methodology

• manual tests
• ran unit tests

Test environment(s)

• Git Extensions 3.1.0
• Build 34bc955
• Git 2.20.1.windows.1
• Microsoft Windows NT 6.1.7601 Service Pack 1
• .NET Framework 4.7.3324.0
• DPI 120dpi (125% scaling)

---

✒️ I contribute this code under The Developer Certificate of Origin.

[mast-eu]

@pmiossec I changed quite a bit what you have implemented in #6293. Could you please have a look?

[RussKie]

@pmiossec are you happy with the changes?

[pmiossec]

@pmiossec are you happy with the changes?

Yes. The only thing that we could improve is that we could remove the last use of FormRemoteProcess.ShowDialog(this, "remote update"); in
https://github.com/gitextensions/gitextensions/blob/master/GitUI/CommandsDialogs/FormRemotes.cs#L450
to also use UICommands.StartPullDialogAndPullImmediately().

[mast-eu]

The only thing that we could improve is that we could remove the last use of FormRemoteProcess.ShowDialog(this, "remote update"); in
https://github.com/gitextensions/gitextensions/blob/master/GitUI/CommandsDialogs/FormRemotes.cs#L450
to also use UICommands.StartPullDialogAndPullImmediately().

Good point. I will add this.

[mast-eu]

I added a commit implementing @pmiossec's suggestion.

[RussKie]

Thank you