Being able to navigate to a PR page of an AppVeyor build

[pmiossec]

Proposed changes

AppVeyor build report contains the data to get the url of the Pull request page.
So add an menu item in the contextual revision grid menu to be able to open the page.

Obviously, this menu item is only displayed when a PR has been built.

Support of GitHub, bitbucket and gitlab for the moment.

PR icon is from https://octicons.github.com/ (MIT licence)

Screenshots

Test methodology

• Manual

Test environment(s)

• Git Extensions 3.1.0
• Build 41f46f7 (Dirty)
• Git 2.20.0.windows.1
• Microsoft Windows NT 10.0.17134.0
• .NET Framework 4.7.3324.0
• DPI 192dpi (200% scaling)

[codecov]

Codecov Report

Merging #6326 into master will increase coverage by 0.35%.
The diff coverage is 54.91%.

@@            Coverage Diff             @@
##           master    #6326      +/-   ##
==========================================
+ Coverage   46.28%   46.64%   +0.35%     
==========================================
  Files         683      687       +4     
  Lines       51297    51641     +344     
  Branches     6729     6805      +76     
==========================================
+ Hits        23741    24086     +345     
+ Misses      26330    26248      -82     
- Partials     1226     1307      +81

Flag	Coverage Δ
#production	36.09% <37.2%> (+0.46%)	⬆️
#tests	97.53% <97.22%> (-0.01%)	⬇️

[RussKie]

Nice 👍

I'd like to see tests for the new functionality.
It would be good to have tests QueryBuildsResults as well. To achieve that it is better to have it refactored by extracting everything below var result = await GetResponseAsync(... line into a separate method.

[RussKie]

Suggested change

	switch (repositoryType)
	switch (repositoryType.ToLowerInvariant())

(though ToUpperInvariant is faster)

[RussKie]

This is redundant

[pmiossec]

done.

[RussKie]

Looks good, few minor tweaks

[RussKie]

Let's move large chunks of input data into physical files and assert the result with ApprovalTests.
Load:

gitextensions/UnitTests/GitCommandsTests/UserRepositoryHistory/Legacy/RepositoryCategoryXmlSerialiserTests.cs

Lines 33 to 39 in d0e8c63

	public void Deserialize_should_load_legacy_categorised_repositories()
	{
	var xml = EmbeddedResourceLoader.Load(Assembly.GetExecutingAssembly(), $"{GetType().Namespace}.MockData.CategorisedRepositories01.xml");
	if (string.IsNullOrWhiteSpace(xml))
	{
	throw new FileFormatException("Unexpected data");
	}

Assert (few overloads available):

gitextensions/UnitTests/GitCommandsTests/UserRepositoryHistory/Legacy/RepositoryCategoryXmlSerialiserTests.cs

Line 105 in d0e8c63

Approvals.VerifyXml(xml);

This will create a testname.approved.txt file that can be viewed in a normal diff viewer. The .approved. files gets committed into the repo.

This will significantly simplify the maintenance of tests and change of data, if necessary.

[pmiossec]

done.

Let's move large chunks of input data into physical files and assert the result with ApprovalTests.

I choose to serialize in Yaml because it's easy to specify a customer serializer (maybe it's possible in json or xml without having to change the tested code....). Indeed, the xml serializer throw due to unable to serialize an interface and json serializer just ignored the data so the test would not have verified all the datas we wanted.

I also have updated the .gitattributes to be able to see the diff on 'approval' files.
And I have added the AppVeyorReporter (because otherwise you can't see why a test crash) but could not have tested it because I solved my failing test on the CI build without it ;p

[RussKie]

I think we can remove this line completely
https://github.com/approvals/ApprovalTests.Net#approved-file-artifacts

Some years ago it was necessary because EOL would change and fail tests.

[RussKie]

LGTM, haven't tested

[pmiossec]

I think we can remove this line completely

done.

[RussKie]

Thank you