Add ability to Copy to Clipboard, similar to commit context menu from left panel

[ghost]

Fixes #6304

Proposed changes

• Create and add to context menu on the left panel CopyContextMenuItem

Screenshots

Before

After

Test methodology

Manually

---

✒️ I contribute this code under The Developer Certificate of Origin.

[codecov]

Codecov Report

Merging #6339 into master will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master    #6339   +/-   ##
=======================================
  Coverage   55.10%   55.11%           
=======================================
  Files         899      899           
  Lines       64756    64776   +20     
  Branches    11627    11629    +2     
=======================================
+ Hits        35685    35699   +14     
- Misses      26340    26344    +4     
- Partials     2731     2733    +2     

Flag	Coverage Δ
#production	42.03% <75.00%> (+0.01%)	⬆️
#tests	94.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[gerhardol]

Seem OK (except for tooltip removal), not tested

[RussKie]

I've checked out your revision. There are some visual artifacts:

• Git Extensions 3.1.0
• Build 3191d22
• Git 2.19.0.windows.1
• Microsoft Windows NT 10.0.17134.0
• .NET Framework 4.7.3260.0
• DPI 144dpi (150% scaling)

[ghost]

For discussion in #8414

We can get git revision on user request.
At the moment of opening the menu. This will be similar to running a command in the console.

public GitRevision GetRevision([CanBeNull] ObjectId objectId = null, bool shortFormat = false, bool loadRefs = false)

Or we can add "GetRevisions" method with commands.

git show branch1 branch2 [list others] --format=%H%n%T%n%P%n%aN%n%aE%n%at%n%cN%n%cE%n%ct%n%e%n --no-patch

And add revision information on tree build

private async Task<Nodes> LoadNodesAsync(CancellationToken token)
{
    await TaskScheduler.Default;
    token.ThrowIfCancellationRequested();

    var branchNames = Module.GetRefs(tags: false, branches: true, noLocks: true).Select(b => b.Name);
    return FillBranchTree(branchNames, token);
}

After

var branchNames = Module.GetRefs(tags: false, branches: true, noLocks: true).Select(b => b.Name);

Most likely there is a way to combine both commands.

---

In the current solution, the situation is similar with hidden branches - it shows the last selected one.

[ghost]

Also for discussion #8414

Text = displayText.TrimEnd('\r', '\n')

For fix

[RussKie]

Also for discussion #8414

Text = displayText.TrimEnd('\r', '\n')

For fix

Yes, I think we'll have to do this 👍

For discussion in #8414

We can get git revision on user request.
At the moment of opening the menu. This will be similar to running a command in the console.

public GitRevision GetRevision([CanBeNull] ObjectId objectId = null, bool shortFormat = false, bool loadRefs = false)

Or we can add "GetRevisions" method with commands.

git show branch1 branch2 [list others] --format=%H%n%T%n%P%n%aN%n%aE%n%at%n%cN%n%cE%n%ct%n%e%n --no-patch

If possible I'd rather reduce a number of commands we run (we run a lot of them as is, some commands are run multiple times during the same operation).
When a user clicks on a node in the left panel, we select the corresponding commit in the revision grid, and from it we have access to the same information if the user were to right click on the grid entry itself.

Pertaining to the discussion in #8414 - if a branch is filtered out of the view, I can't see a good use case where we need to bend over backwards to provide extra information for it. Similar to an inactive remote - there's no information until it is activated and fetched.

[RussKie]

👍
Currently blocked by #8434 and #8414 due to pending infra changes.

[ghost]

Pertaining to the discussion in #8414 - if a branch is filtered out of the view, I can't see a good use case where we need to bend over backwards to provide extra information for it. Similar to an inactive remote - there's no information until it is activated and fetched.

I understand correctly that there is no separation between model and view. Everything is stored in a grid, and after deletion you need to access the repository?

[ghost]

As I imagine, we have a hash of the commit, and we can get all the necessary information from the model by the hash. (ObjectId)
But that's not how it works now.

[RussKie]

I understand correctly that there is no separation between model and view. Everything is stored in a grid, and after deletion you need to access the repository?

Correct, unfortunately there's no separation (and it does bother me). And this makes a lot of thing significantly harder than they should be. E.g. we do a lot of refreshes, which cause flicker, and result in multiple git calls.
Ideally the grid should just bind to an observable list of commits.

[ghost]

Removed the display for the hidden node.

[RussKie]

I ran it locally, and something isn't working 100% but I couldn't quite see from the diff.

When I right click on the latest master (4355746) in the revision grid and select copy commit:

I get the following:

Merge pull request #8527 from BrianFreemanAtlanta/RemoveFilesUpdateNameTooLong

updated removeFiles to use GetBatchOutput and added unit tests

When I do the same from the left panel I only get the first line:

Merge pull request #8527 from BrianFreemanAtlanta/RemoveFilesUpdateNameTooLong

[ghost]

Changed revisions provider.

copyContextMenuItem.SetRevisionFunc(() => _scriptHost.GetSelectedRevisions());

[RussKie]

Thank you 🎉

This certainly has been a long journey, thank you for sticking around.