Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor plugin: Prevent crash when trying to add the same project again #6426

Merged
merged 1 commit into from Mar 31, 2019

Conversation

pmiossec
Copy link
Member

that could happens if you open a form that display CI results
quickly after starting GitExtensions (and that the plugin has not finished
to be initialized in the browse form)

Steps to reproduce

  • Open GitExtension repository (which use AppVeyor CI build)
  • Very quickly , open the blame form
  • Crash!

#Screenshots

##Before

image

##After

No more exception.

Test methodology

  • Manual

Test environment(s)

  • Git Extensions 3.1.0
  • Build 6c85524 (Dirty)
  • Git 2.20.1.windows.1
  • Microsoft Windows NT 10.0.17134.0
  • .NET Framework 4.7.3324.0
  • DPI 96dpi (no scaling)

✒️ I contribute this code under The Developer Certificate of Origin.

that could happens if you open a form that display CI results
quickly after starting GitExtensions (and that the plugin has not finished
to be initialized in the browse form)
@codecov
Copy link

codecov bot commented Mar 30, 2019

Codecov Report

Merging #6426 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #6426      +/-   ##
==========================================
- Coverage   46.72%   46.71%   -0.01%     
==========================================
  Files         688      688              
  Lines       51807    51808       +1     
  Branches     6813     6814       +1     
==========================================
- Hits        24206    24202       -4     
- Misses      26283    26288       +5     
  Partials     1318     1318
Flag Coverage Δ
#production 36.16% <0%> (-0.02%) ⬇️
#tests 97.51% <ø> (ø) ⬆️

@RussKie RussKie merged commit 259c501 into gitextensions:master Mar 31, 2019
@RussKie RussKie added this to the 3.1.0 milestone Mar 31, 2019
@pmiossec pmiossec deleted the fix_crash_appveyor branch April 1, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants