Detailed submodule status in dropdown menu was not updated #6444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #6444 +/- ##
==========================================
+ Coverage 46.88% 46.88% +<.01%
==========================================
Files 688 688
Lines 51953 51954 +1
Branches 6836 6836
==========================================
+ Hits 24358 24359 +1
+ Misses 26253 26251 -2
- Partials 1342 1344 +2
|
gerhardol
added
the
type: regression
|
🤔 A seditious thought, having the left panel can we remove the toolbar item completely? |
|
🤔 A seditious thought, having the left panel can we remove the toolbar
item completely?
I don't use submodules but I think we can't do it (at least at the moment)
because that obliged people to use the left panel which could be
problematic in terms of screen space and also maybe in terms of performance
(we have seen that the left panel slow down repository refresh in some
cases and I don't know if it was completely solved).
… |
Not in 3.1, I expect that we should transition users first.
The left panel should have very minimal impact. |
|
👍 |
|
Plan to merge this trivial regression tonight |
gerhardol
force-pushed
the
bugfix/p6372-submodule-menu-status
branch
from
e84d9eb
to
0d2e694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #6372
Proposed changes
The submenu status in the dropdown menu was not updated after rework in #6372
As a not released regression, this is not added to the 3.1.0 milestone
Screenshots
Before
After
Test methodology
Manual test: Make a test to a submodule
Test environment(s)
✒️ I contribute this code under The Developer Certificate of Origin.