Generate avatars with author initials as fallback of gravatar #6499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
@@ Coverage Diff @@
## master #6499 +/- ##
==========================================
+ Coverage 46.98% 47.01% +0.02%
==========================================
Files 694 696 +2
Lines 52314 52393 +79
Branches 6874 6882 +8
==========================================
+ Hits 24582 24631 +49
- Misses 26409 26436 +27
- Partials 1323 1326 +3
|
gerhardol
approved these changes
Apr 22, 2019
| private readonly Brush _textBrush = new SolidBrush(Color.WhiteSmoke); | ||
| private readonly Color[] _avatarColors = | ||
| { | ||
| Color.RoyalBlue, |
There was a problem hiding this comment.
Note for theming: May need customization. (I thought about asking for more colors too, but it should be OK).
RussKie
reviewed
Apr 23, 2019
|
|
||
| drawing.Save(); | ||
|
|
||
| drawing.Dispose(); |
There was a problem hiding this comment.
Could we instead write
using (var drawing = Graphics.FromImage(img))
{
drawing.Clear(backColor);
// ...
drawing.Save();
}
There was a problem hiding this comment.
Indeed. I don't know why I haven't seen it.
Anyway... fixed.
pmiossec
force-pushed
the
author_initials_avatar_as_gravatar_fallback
branch
from
c937777
to
07ae765
Compare
|
Works well 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A smaller step than #6417 as it requires no ("not everyone agrees") UI changes but bringing most of the added value...
Proposed changes
Screenshots
Before
After
Test methodology
Test environment(s)
✒️ I contribute this code under The Developer Certificate of Origin.