Bugfix script option {sRemotePathFromUrl}

[mstv]

Fixes #6567

Proposed changes

• Complete the refactoring done in Fix #5999: Add option to quote arguments in script parser #6004 for sRemotePathFromUrl

Test methodology

• added NUnit tests

---

✒️ I contribute this code under The Developer Certificate of Origin.

[mstv]

@jeroendv, could you test the canary build 5886, please?

[jeroendv]

@jeroendv, could you test the canary build 5886, please?

I can confirm that the bug is fixed.

[mstv]

I can confirm that the bug is fixed.

Thank you.

[RussKie]

I don't expect test for the whole parser (unless you want to). Just for the immediate change. Thank you

…

On Sun, May 19, 2019, 9:02 AM Michael Seibt ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In GitUI/Script/ScriptOptionsParser.cs <#6573 (comment)> : > @@ -349,7 +349,8 @@ private static string ParseScriptArguments(string argument, string option, IWin3 remote = selectedRemotes.Count == 1 ? selectedRemotes[0] : AskToSpecify(selectedRemotes, revisionGrid); - newString = module.GetSetting(string.Format(SettingKeyString.RemoteUrl, remote)); + url = module.GetSetting(string.Format(SettingKeyString.RemoteUrl, remote)); + newString = GetRemotePath(url); I'll add some tests but not for every script option. (We should have asked for tests before the ScriptOptionParser was refactored. This is at least the second bug caused by this refactoring.) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#6573?email_source=notifications&email_token=ABBTEXVJN2D6T26QNSQAOZDPWCDJXA5CNFSM4HNHRTO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZBCH6Y#discussion_r285358669>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBTEXU45FPZMBDJOMD5EQ3PWCDJXANCNFSM4HNHRTOQ> .

[codecov]

Codecov Report

Merging #6573 into master will increase coverage by 0.16%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #6573      +/-   ##
==========================================
+ Coverage   47.06%   47.23%   +0.16%     
==========================================
  Files         698      698              
  Lines       52636    52670      +34     
  Branches     6942     6942              
==========================================
+ Hits        24774    24879     +105     
+ Misses      26544    26450      -94     
- Partials     1318     1341      +23

Flag	Coverage Δ
#production	36.54% <100%> (+0.16%)	⬆️
#tests	97.6% <100%> (ø)	⬆️