Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ctrl+Backspace affecting ReadOnly TextBox #6668

Merged
merged 1 commit into from
May 26, 2019
Merged

Fix Ctrl+Backspace affecting ReadOnly TextBox #6668

merged 1 commit into from
May 26, 2019

Conversation

NikolayXHD
Copy link
Member

@NikolayXHD NikolayXHD commented May 25, 2019

Fixes #6667 introduced by #6256

Test methodology

Manually verified the problem from screenshot below was fixed.

image

Test environment(s)

  • Windows 7 SP1

✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned NikolayXHD May 25, 2019
@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #6668 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #6668      +/-   ##
==========================================
- Coverage   47.35%   47.23%   -0.12%     
==========================================
  Files         704      704              
  Lines       52779    52778       -1     
  Branches     6952     6953       +1     
==========================================
- Hits        24993    24930      -63     
- Misses      26444    26528      +84     
+ Partials     1342     1320      -22
Flag Coverage Δ
#production 36.48% <0%> (-0.15%) ⬇️
#tests 97.61% <ø> (ø) ⬆️

@RussKie
Copy link
Member

RussKie commented May 26, 2019

Thank you.

Btw have you seen how the similar behaviour was implemented in dotnet/winforms#629?

@RussKie RussKie merged commit 3183bd9 into gitextensions:master May 26, 2019
@NikolayXHD
Copy link
Member Author

NikolayXHD commented May 26, 2019

Thank you.

Btw have you seen how the similar behaviour was implemented in dotnet/winforms#629?

Thanks for pointing me to it. Looking at it I found a similar case I missed here: ComboBox when DropDownStyle == ComboBoxStyle.DropDownList should not be affected by hotkey as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl+Backspace affects ReadOnly TextBox
2 participants