Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Blame: Fix "blame previous revision" feature #6841
For the 2nd point (the 1st change nothing to the ui)
Focus only on the menu (and not the colors of the lines)
@@ Coverage Diff @@ ## master #6841 +/- ## ========================================= + Coverage 47.68% 47.7% +0.01% ========================================= Files 731 731 Lines 53901 53912 +11 Branches 7073 7075 +2 ========================================= + Hits 25703 25719 +16 - Misses 26803 26805 +2 + Partials 1395 1388 -7
Still open: The lines of
The disabling of the context menu items can be done in the second PR.
@mstv I think I have fixed most of the things related to this PR and that I won't add much.
The 2 others improvements you ask we to do are not really related to the original goal of this PR just intended to fix the 'blame previous commit' feature.
Yes, I would like to see it fixed in another PR but I want to wait for the rename regression before working on it.
So, except the last review comment, I think this PR is in good state to be merged...
Looking at the code, I don't see how to achieve it with unit tests because under the hood, it relies on
With integration tests, it should be achievable (with a lot of work).