refactor: Move email settings from General to Detailed #6881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
RussKie
force-pushed
the
Move_email_settings_to_Detailed_page
branch
from
4fa681a
to
77978c2
Compare
|
With thais change, the size of the settings window could have been decreased. Maybe split performance and behavior too. |
We'll have nothing left on the page then 😄 There was a good discussion (way before my time) #1707 that discussed Settings. It is worth having a discussion again. |
|
The settings have been cleaned up since that discussion but it could be discussed again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
GeneraltoDetailedScreenshots
Before
After
✒️ I contribute this code under The Developer Certificate of Origin.