Open jira settings when not configured

[pmiossec]

Proposed changes

• Fix a bad check if settings exists
• open the settings if not configured

Test methodology

• manual

Test environment(s)

• Git Extensions 3.2.0
• Build 885dbb8
• Git 2.21.0.windows.1 (recommended: 2.22.0 or later)
• Microsoft Windows NT 10.0.17134.0
• .NET Framework 4.7.3416.0
• DPI 192dpi (200% scaling)

[gerhardol]

Does this work at all now?

[RussKie]

Could you please explain the use case, it is not clear to me what was wrong that we're fixing here.

[pmiossec]

Could you please explain the use case, it is not clear to me what was wrong that we're fixing here.

It's just a little fix and improvement.

Before this PR, we had a Jira Commit Hint menu item in the 'Plugin' Menu that does nothing.

I discovered, when developing the same plugin for Azure DevOps that a feature was written to show a message box with an example of a commit message by querying Jira with all the parameters (not a great value but why not).

The first commit fix the condition to enable this feature.

And while I was there, I did the same thing that we do on some other plugin , that is, to display the settings window when the plugin is not configured. This is the changed introduced in the 2nd commit. Even if you don't have Jira (I don't, I just backport from the AzureDevops plugin), you could test this part.

Does this work at all now?

@gerhardol So, yes, it works now 😉

[RussKie]

Merge if @gerhardol is happy

[pmiossec]

Merge if @gerhardol is happy

So, I let @gerhardol merge it 😉