Display icons in commit templates menu items

[pmiossec]

Proposed changes

• Display icons (especially the one of the Jira commit hint plugin) in commit templates menu items

PS: I have created because I'm mostly interested by the api change that it introduce (most of the code is common, there is just one line to update in the commit hint plugin).

Screenshots

Before

After

With provider:

Without provider (don't block on the Azure DevOps icon, this PR add Jira icon but I only can test it with the AzureDevOps plugin I'm developping...):

Test methodology

• Manual

Test environment(s)

• Git Extensions 3.2.0
• Build 4bb4263
• Git 2.21.0.windows.1 (recommended: 2.22.0 or later)
• Microsoft Windows NT 10.0.17134.0
• .NET Framework 4.7.3416.0
• DPI 192dpi (200% scaling)

[RussKie]

LGTM, subject to the my comment

[RussKie]

We already have this icon, though it is probably under a different name:

Please re-use it instead of adding a new resource

[pmiossec]

Thanks. I didn't know of the Images resources. I was miss leaded by the fact that there are images in the Resources resources.

[RussKie]

Squash and merge at will

…

On Thu, Aug 22, 2019, 10:44 AM Philippe Miossec ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In GitUI/Properties/Resources.Designer.cs <#7037 (comment)> : > @@ -254,6 +254,16 @@ internal class Resources { } } + /// <summary> + /// Looks up a localized resource of type System.Drawing.Bitmap. + /// </summary> + internal static System.Drawing.Bitmap Settings { Thanks. I didn't know of the Images resources. I was miss leaded by the fact that there are images in the Resources resources. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#7037?email_source=notifications&email_token=ABBTEXVN4UMOWHJBERR6H2LQFY7VNA5CNFSM4IOIWQZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCK2HVQ#discussion_r316537420>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBTEXQZMITHZHHAPGNBEB3QFY7VNANCNFSM4IOIWQZA> .