prevent flickering when selecting files in staged/unstaged FileStatusList #7267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
mdonatas
commented
Oct 8, 2019
Codecov Report
@@ Coverage Diff @@
## master #7267 +/- ##
=========================================
- Coverage 48.01% 48% -0.01%
=========================================
Files 747 748 +1
Lines 54807 54819 +12
Branches 7146 7148 +2
=========================================
+ Hits 26316 26318 +2
- Misses 27081 27084 +3
- Partials 1410 1417 +7
|
|
To confirm - if use tab to cycle between controls, we don't get flickering, do we? |
mdonatas
force-pushed
the
prvent-formcommit-diff-flicker
branch
from
76437bf
to
acf2fe0
Compare
mdonatas
commented
Oct 9, 2019
| { | ||
| if (m.Msg == NativeConstants.WM_MOUSEACTIVATE) | ||
| { | ||
| _mouseEntered = !Focused; |
There was a problem hiding this comment.
Changed this from simply true to !Focused as if you'd click on a list a second time this would get set to true and would remain so as Enter would not fire and this would not get reset to False.
Found this after some more manual testing.
We don't with this fix and we didn't as when you'd tab around the first item gets selected so even if it used to flicker technically it wasn't visible as it'd flicker between the same item. |
RussKie
approved these changes
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7266
Proposed changes
Enteringthe control by keyboard as when using the mouse you either click on specific item to select it or on an empty space to deselect everythingEnterevent toFileStatusListwhich would provide extra details as to how control was enteredTest methodology