Select multiple revisions using Left Panel #8056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8056 +/- ##
==========================================
+ Coverage 49.54% 49.56% +0.01%
==========================================
Files 846 846
Lines 60878 60895 +17
Branches 10915 10918 +3
==========================================
+ Hits 30164 30182 +18
- Misses 28488 28493 +5
+ Partials 2226 2220 -6
|
mstv
force-pushed
the
feature/rot_multiselect
branch
from
e3ee536
to
c267614
Compare
RussKie
approved these changes
May 3, 2020
mstv
force-pushed
the
feature/rot_multiselect
branch
from
c267614
to
03da69a
Compare
- factor out local function EnsureRowVisible - call _gridView.Select() first (was omitted by too early return)
especially if triggered from left panel
mstv
force-pushed
the
feature/rot_multiselect
branch
from
03da69a
to
927b317
Compare
|
@msftbot merge in 8 hours |
ghost
added
the
|
Hello @mstv! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
gerhardol
reviewed
May 3, 2020
ghost
merged commit
|
927b317 causes a regression |
Oops, fixing. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Improve revision selection Left Panel vs. RevisionGrid:
NativeTreeViewExplorerNavigationDecorator:Use the given lambda instead of
DateTime.Now.RevisionGridControl.InitialObjectIdafter use. (Might be related to Refreshing is changing selected commit #6057.)RevisionGridControl.SetSelectedIndex:EnsureRowVisible_gridView.Select()first (was omitted by too earlyreturnfrom my previous PR)Ctrlis pressed especially if triggered from left panel.Screenshots
Before
result of
Ctrl+ClickAfter
Test methodology
Test environment(s)
✒️ I contribute this code under The Developer Certificate of Origin.