Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch all types of exception thrown by ReadAllText #8075

Merged
merged 1 commit into from May 7, 2020

Conversation

mstv
Copy link
Member

@mstv mstv commented May 6, 2020

Fixes #8074

Proposed changes

  • Ignore all types of exception which can be thrown by File.ReadAllText in GetSelectedBranchFast

Test methodology

  • manual

Test environment(s)

  • Git Extensions 3.3.0
  • Build c06c3ae
  • Git 2.26.0.windows.1
  • Microsoft Windows NT 6.2.9200.0
  • .NET Framework 4.8.4121.0
  • DPI 96dpi (no scaling)

✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this May 6, 2020
@mstv
Copy link
Member Author

mstv commented May 7, 2020

@msftbot merge in 1 day

@ghost ghost added the status: auto merge label May 7, 2020
@ghost
Copy link

ghost commented May 7, 2020

Hello @mstv!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Fri, 08 May 2020 19:35:21 GMT, which is in 1 day

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@mstv mstv merged commit 76b9c2a into gitextensions:master May 7, 2020
@ghost ghost added this to the 4.0 milestone May 7, 2020
@mstv mstv deleted the fix/8057_GetSelectedBranchFast branch May 7, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NBug] UnauthorizedAccessException in GetSelectedBranchFast
3 participants