Improve "Limit number of commits" option

[bansan85]

Fixes #8083

Proposed changes

• It shouldn't be necessary to restart GE to apply the new value.
• Disable limitation should not be an undocumented feature.

Screenshots

Before

After

Test methodology

None

Test environment(s)

• Git Extensions 3.3.0
• Build d47d27e
• Git 2.26.2.windows.1
• Microsoft Windows NT 6.2.9200.0
• .NET Framework 4.8.4150.0
• DPI 96dpi (no scaling)

---

✒️ I contribute this code under The Developer Certificate of Origin.

[mstv]

Is the limit applied now?

The label is too short now IMO, i.e. add " to be loaded" or the like.

I guess disabling will result in 🤔:

[codecov]

Codecov Report

Merging #8084 into master will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #8084      +/-   ##
==========================================
- Coverage   52.75%   52.74%   -0.02%     
==========================================
  Files         866      866              
  Lines       62689    62697       +8     
  Branches    11300    11302       +2     
==========================================
- Hits        33070    33067       -3     
- Misses      26977    26981       +4     
- Partials     2642     2649       +7     

Flag	Coverage Δ
#production	40.73% <33.33%> (-0.01%)	⬇️
#tests	94.20% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[bansan85]

Is the limit applied now?

It's the same behavior than before (except it's applied when the window is closed) :

• if 0 then no limitation,
• if not 0 then limitation is applied,

It's just that if you uncheck the option, the limitation is forced to disable.

The label is too short now IMO, i.e. add " to be loaded" or the like.

Are you sure ? I like this short text. If it not bothing you, I would like a second opinion.

I guess disabling will result in 🤔:

No : unchecking the checkbox disables the NumeripUpDown but it does not force the value in NumericUpDown to 0. It's in case someone unchecks by mistake, it's easy reversable. But if you uncheck the box and close the window, the value is definitly 0.

[RussKie]

LGTM

[pmiossec]

The label is too short now IMO, i.e. add " to be loaded" or the like.

Are you sure ? I like this short text. If it not bothing you, I would like a second opinion.

When this PR was discussed, I was pretty sure we were talking of the option placed in the View => Set advanced filter which is really similar.
In that case, either of the label was good for me.

But I just realized that it is another option that was discussed about here. And I must admit that I agree with @mstv and because we don't have a context here, the label must be very explicit for the user and the one chosen here is not clear enough.

Sorry to be late in the discussion...

Per other feedback

[ghost]

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 30 days. It will be closed if no further activity occurs.

[bansan85]

Sorry, I forget about this PR :/

I changed the text of the option to "Limit number of commits to be loaded".

[pmiossec]

Thank you. I forgot also 😅