New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply also font size setting to the ConEmu popup #8215
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8215 +/- ##
==========================================
- Coverage 52.78% 52.77% -0.01%
==========================================
Files 857 857
Lines 62339 62316 -23
Branches 11202 11197 -5
==========================================
- Hits 32907 32890 -17
+ Misses 26827 26824 -3
+ Partials 2605 2602 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works and makes sense to me, espcially with respect to the welcome move of the settings proposed in #8214,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change should be moved into ConEmu project as it is tightly coupled with it.
We have diverged from the upstream and will not be sync'ing with it.
Updated following merge of gitextensions/conemu-inside#21 |
Proposed changes
Screenshots
Before
After
That's bigger (even if we don't really see it due to how GitHub handle images. Compare text size inside the console with the one of the button or with the icon size)
Test methodology
Test environment(s)