Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply also font size setting to the ConEmu popup #8215

Merged
merged 1 commit into from Jul 4, 2020

Conversation

pmiossec
Copy link
Member

@pmiossec pmiossec commented Jun 12, 2020

Proposed changes

  • Apply also the Conemu font configuration to the ConEmu popup (because that's strange to apply only just one setting, the console style and not the other)

Screenshots

Before

image

After

That's bigger (even if we don't really see it due to how GitHub handle images. Compare text size inside the console with the one of the button or with the icon size)

image

Test methodology

  • Manual

Test environment(s)

  • Git Extensions 33.33.33
  • Build f544aba (Dirty)
  • Git 2.25.0.windows.1 (recommended: 2.25.1 or later)
  • Microsoft Windows NT 6.2.9200.0
  • .NET Framework 4.8.4180.0
  • DPI 168dpi (175% scaling)

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #8215 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #8215      +/-   ##
==========================================
- Coverage   52.78%   52.77%   -0.01%     
==========================================
  Files         857      857              
  Lines       62339    62316      -23     
  Branches    11202    11197       -5     
==========================================
- Hits        32907    32890      -17     
+ Misses      26827    26824       -3     
+ Partials     2605     2602       -3     
Flag Coverage Δ
#production 40.74% <50.00%> (-0.02%) ⬇️
#tests 94.46% <ø> (ø)

Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and makes sense to me, espcially with respect to the welcome move of the settings proposed in #8214,

Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change should be moved into ConEmu project as it is tightly coupled with it.
We have diverged from the upstream and will not be sync'ing with it.

GitUI/UserControls/ConsoleEmulatorOutputControl.cs Outdated Show resolved Hide resolved
@ghost ghost added the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Jun 14, 2020
@ghost ghost removed the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Jul 3, 2020
@pmiossec
Copy link
Member Author

pmiossec commented Jul 4, 2020

Updated following merge of gitextensions/conemu-inside#21

@mstv mstv merged commit 59f82a0 into gitextensions:master Jul 4, 2020
@ghost ghost added this to the 4.0 milestone Jul 4, 2020
@pmiossec pmiossec deleted the conemu_font branch July 17, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants