fix ignoring app.manifest #8218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that correct version of comctl32.dll is loaded
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## release/3.4 #8218 +/- ##
===============================================
+ Coverage 49.53% 49.57% +0.03%
===============================================
Files 852 852
Lines 61292 61292
Branches 11015 11015
===============================================
+ Hits 30363 30387 +24
+ Misses 28661 28624 -37
- Partials 2268 2281 +13
|
RussKie
approved these changes
Jun 14, 2020
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8208
Test methodology
Tested manually with
C:\Program Files\Gitrenamed to Git2Test environment(s)
Windows 10
✒️ I contribute this code under The Developer Certificate of Origin.