Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hint regarding updates of portable builds #8273

Merged
merged 1 commit into from Jul 1, 2020

Conversation

mstv
Copy link
Member

@mstv mstv commented Jun 26, 2020

Proposed changes

  • add hint to README.md

Feel free to tinker / move the text how and where you like it better!

Screenshots

Before

grafik

After

grafik


✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this Jun 26, 2020
@mstv mstv mentioned this pull request Jun 26, 2020
Copy link
Member

@pmiossec pmiossec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I planned to do it so 👍
But you did it a lot better than what I imagined to do, so 👍👍👍👍

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #8273 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8273   +/-   ##
=======================================
  Coverage   50.13%   50.13%           
=======================================
  Files         853      853           
  Lines       61934    61934           
  Branches    11109    11109           
=======================================
+ Hits        31049    31052    +3     
  Misses      28544    28544           
+ Partials     2341     2338    -3     
Flag Coverage Δ
#production 37.62% <ø> (+<0.01%) ⬆️
#tests 94.42% <ø> (ø)

@vbjay
Copy link
Contributor

vbjay commented Jun 26, 2020 via email

@RussKie
Copy link
Member

RussKie commented Jun 27, 2020

Thank you

Would it be more appropriate to add to the actual release page, where a user would download a portable version from?
https://github.com/gitextensions/gitextensions/releases/tag/v3.4.2

@gerhardol
Copy link
Member

I suggest a link from the release page to the readme

@mstv
Copy link
Member Author

mstv commented Jun 27, 2020

What about plugins?

My knowledge about plugins it very limited. Any info?

Would it be more appropriate to add to the actual release page, where a user would download a portable version from?

We should have it in both places: It applies to dev builds, too.
Is the release page copied automatically when creating a new releases? Or must it be added manually for every release?

I suggest a link from the release page to the readme.

Yes, it avoids copies, which tend to get out of sync.

@RussKie RussKie merged commit 2b7df30 into gitextensions:master Jul 1, 2020
@ghost ghost added this to the 4.0 milestone Jul 1, 2020
@RussKie
Copy link
Member

RussKie commented Jul 1, 2020

Thank you

@mstv mstv deleted the portable_hint branch July 3, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants