Refactor to replace magic hash string with variable #8305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #8305 +/- ##
==========================================
- Coverage 52.66% 51.33% -1.34%
==========================================
Files 863 847 -16
Lines 62503 60549 -1954
Branches 11189 10866 -323
==========================================
- Hits 32916 31080 -1836
- Misses 26965 26969 +4
+ Partials 2622 2500 -122
|
RussKie
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nothing
Proposed changes
Replace magic string SHA in unit test with variable
Test methodology
Test environment(s)
✒️ I contribute this code under The Developer Certificate of Origin.