Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up of status reporting of failed operations #8311

Merged
merged 4 commits into from
Jul 15, 2020
Merged

Clean up of status reporting of failed operations #8311

merged 4 commits into from
Jul 15, 2020

Commits on Jul 12, 2020

  1. Clean up of status reporting of failed operations 

    Undo plumbing and infra introduced in 1572cbd.
With that we have one less dependency on WPF stack.

There are several scenarios that involve showing `FormStatus` or its descendants.
1. Show a progress as a modal dialog (this is standard way).
2. Do not show the progress dialog, and only show it if an operation that
was running failed (e.g. staging files in `FormCommit`).

The approach to showing results of failed operations appears to be unnecessay
complex, that IIUC led to issues while attempting to show a dialog that was
already considered opened but invisible.
And the WPF's DispatcherFrameModalController was used to deal with this.
This also necessitated defining delegates, and required more plumbing to
pass those around, validation, etc.

However it is much simpler *not* to show the dialog *until after* the operation
has failed.
The callsites are also much easier to read and understand.
    @RussKie
    RussKie committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    163952c View commit details
    Browse the repository at this point in the history

  2. Remove duplicated methods

    @RussKie
    RussKie committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    4fc5e53 View commit details
    Browse the repository at this point in the history

  3. Adjust member visibility

    @RussKie
    RussKie committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    034c0f7 View commit details
    Browse the repository at this point in the history

  4. Shuffle members around (no functional changes)

    @RussKie
    RussKie committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    e3e4a03 View commit details
    Browse the repository at this point in the history