Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gource avatar feature #8322

Merged
merged 3 commits into from Jul 15, 2020

Conversation

pmiossec
Copy link
Member

@pmiossec pmiossec commented Jul 13, 2020

by generating the avatars in the expected format by Gource:
i.e. authorname.png

The previously generated file were not found by Gource...

From Gource documentation:

    --user-image-dir DIRECTORY
            Directory containing .jpg or .png images of users
            (eg "Full Name.png") to use as avatars.

Screenshots

Before

image

After

image

Test methodology

  • Manual

Test environment(s)

  • Git Extensions 33.33.33
  • Build dee83f5
  • Git 2.25.0.windows.1 (recommended: 2.25.1 or later)
  • Microsoft Windows NT 10.0.17134.0
  • .NET Framework 4.8.4180.0
  • DPI 168dpi (175% scaling)

by generating the avatars in the expected format by Gource:
i.e. `authorname.png`
@ghost ghost assigned pmiossec Jul 13, 2020
@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #8322 into master will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8322      +/-   ##
==========================================
+ Coverage   52.65%   52.82%   +0.17%     
==========================================
  Files         864      861       -3     
  Lines       62545    62244     -301     
  Branches    11201    11101     -100     
==========================================
- Hits        32930    32881      -49     
+ Misses      26991    26770     -221     
+ Partials     2624     2593      -31     
Flag Coverage Δ
#production 40.81% <ø> (+0.15%) ⬆️
#tests 94.45% <ø> (ø)

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not run it but it makes sense

@pmiossec
Copy link
Member Author

@msftbot merge in 1 day

@ghost ghost added the status: auto merge label Jul 15, 2020
@ghost
Copy link

ghost commented Jul 15, 2020

Hello @pmiossec!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 16 Jul 2020 07:55:29 GMT, which is in 1 day

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@RussKie RussKie merged commit 1238c16 into gitextensions:master Jul 15, 2020
@ghost ghost added this to the 4.0 milestone Jul 15, 2020
@pmiossec pmiossec deleted the fix_gource_avatar_feature branch July 15, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants