Dark titlebar when using a dark theme on a recent Win10

[pmiossec]

Proposed changes

• Set a dark titlebar when using a dark theme when the user use a supported version of Win10

Screenshots

Before

The title bar is always white...

After

light theme:

dark theme:

Test methodology

• Manual

Test environment(s)

• Git Extensions 33.33.33
• Build 26402f0898e7107f5b8978fa8c8a2416198a864b
• Git 2.27.0.windows.1
• Microsoft Windows NT 10.0.19041.0
• .NET Framework 4.8.4180.0
• DPI 96dpi (no scaling)

---

✒️ I contribute this code under The Developer Certificate of Origin.

[codecov]

Codecov Report

Merging #8435 into master will decrease coverage by 0.02%.
The diff coverage is 6.25%.

@@            Coverage Diff             @@
##           master    #8435      +/-   ##
==========================================
- Coverage   53.02%   52.99%   -0.03%     
==========================================
  Files         869      870       +1     
  Lines       62066    62082      +16     
  Branches    11302    11309       +7     
==========================================
- Hits        32908    32898      -10     
- Misses      26502    26518      +16     
- Partials     2656     2666      +10     

Flag	Coverage Δ
#production	40.94% <6.25%> (-0.04%)	⬇️
#tests	94.26% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[tebeco]

@pmiossec

Given the diff shown by github (which include older commits) is it the good base branch (or you might have an older base branch on your fork ?)
As these commits are part of a PR for colorblind it might be on purpose, just curious though

[RussKie]

We should really give credit when copying code 😉
https://stackoverflow.com/a/62811758/2338036

[pmiossec]

Given the diff shown by github (which include older commits) is it the good base branch (or you might have an older base branch on your fork ?)
As these commits are part of a PR for colorblind it might be on purpose, just curious though

@tebeco

that's because the branch is based on #8424 (because it introduces change around theme and I wanted to be sure to avoid future conflicts) and so it will be merged after.

[NikolayXHD]

@pmiossec fantastic! Few days ago I noticed Telegram messenger app does this, so I thought there must be a way, tried looking it up, failed, and here you are!

[pmiossec]

@pmiossec fantastic! Few days ago I noticed Telegram messenger app does this, so I thought there must be a way, tried looking it up, failed, and here you are!

I deserve very few credits.
Credits goes to:

• @halter73 for noticing the possible improvement
• @tebeco for telling it to me and providing the stackoverflow answer containing the solution.

I just did a quick dev and the PR. Testing was a little more difficult because my Win10 is too old 😢

[tebeco]

I'll take my shoot here since I've spotted this

• Is that a bot that need to be reported ?
• Is "Code review" open to all Github on Git Extensions ? (@RussKie open/influenced to weird bot/account if that's one)

on this PR:

on an older PR:

[pmiossec]

* Is that a bot that need to be reported ?

3 or 4 useless comments in 2 or 3 days. So maybe yes...

* Is "Code review" open to all Github on `Git Extensions` ?

yes. So, contribute! 😉

[RussKie]

Anyone and everyone is welcome to review open (and closed) pull requests. The final decision to take or reject changes lies with the members of the core team though.

[gerhardol]

10.0.19041

[pmiossec]

Done

[drewnoakes]

This is a great improvement to the dark mode. Thanks very much to all involved.

[RussKie]

Few more nits

[RussKie]

that's it

[RussKie]

Thank you