Settings updated event [cleanup]

[ghost]

Continuation #8450

Proposed changes

• Add the ability to receive an event about a change in the setting value.
• Also, in the future, we can remove all classes inherited from Setting and use one generic.

Screenshots

After

We can replace

And use

Test methodology

• Manual

Test environment(s)

• Git Extensions 3.4.3.9999
• Build d4b0f48
• Git 2.28.0.windows.1
• Microsoft Windows NT 10.0.19041.0
• .NET Framework 4.8.4220.0
• DPI 96dpi (no scaling)

---

✒️ I contribute this code under The Developer Certificate of Origin.

[ghost]

@RussKie could you please do a review.

[codecov]

Codecov Report

Merging #8451 into master will increase coverage by 0.12%.
The diff coverage is 53.33%.

@@            Coverage Diff             @@
##           master    #8451      +/-   ##
==========================================
+ Coverage   53.00%   53.12%   +0.12%     
==========================================
  Files         877      880       +3     
  Lines       62129    62364     +235     
  Branches    11331    11348      +17     
==========================================
+ Hits        32930    33131     +201     
- Misses      26532    26565      +33     
- Partials     2667     2668       +1     

Flag	Coverage Δ
#production	41.03% <53.33%> (+0.06%)	⬆️
#tests	94.31% <ø> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[RussKie]

So if we get more properties that we can wire up events too we should consider INotifyPropertyChanged?

[RussKie]

👍

[ghost]

So if we get more properties that we can wire up events too we should consider INotifyPropertyChanged?

We still have one property "Value"
The rest are constant or depend on "Value"

[RussKie]

So if we get more properties that we can wire up events too we should consider INotifyPropertyChanged?

We still have one property "Value"
The rest are constant or depend on "Value"

I'm thinking instead of

have something that works for every settings, e.g.:

AppSetitngs.SettingChanged += (s, e) => { ... }

[ghost]

We have different settings, this may require more changes.
We also need to know that this particular setting has been updated.
Better if it's in one place. At least for now.

[ghost]

[RussKie]

Ugh... we'll have to deal with it one day :)

[RussKie]

I had a go at refactoring it 3 years ago (ugh!) https://github.com/RussKie/gitextensions/tree/refactor_AppSettings

[ghost]

I had a go at refactoring it 3 years ago (ugh!) https://github.com/RussKie/gitextensions/tree/refactor_AppSettings

Are you planning to apply these changes?

[RussKie]

I had a go at refactoring it 3 years ago (ugh!) https://github.com/RussKie/gitextensions/tree/refactor_AppSettings

Are you planning to apply these changes?

Maybe... One day.... When I have completed other things :) There are so many things I'd like to do, and there's so much time I have for this project.
Feel free to use it.

[ghost]

Renamed DefaultValue to Default