Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow highlight branch by ALT+Click in the grid #8452

Merged
merged 1 commit into from Jul 28, 2022
Merged

Allow highlight branch by ALT+Click in the grid #8452

merged 1 commit into from Jul 28, 2022

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Sep 13, 2020 •
edited by gerhardol

Proposed changes

Expose the same behaviour as "Highlight selected branch" in the revision grid via ALT+Left Click, similar to the default hotkey CTRL+Shift+B.

image

@ghost ghost assigned RussKie Sep 13, 2020
@codecov
Copy link

codecov bot commented Sep 13, 2020 •
edited

Codecov Report

Merging #8452 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #8452      +/-   ##
==========================================
- Coverage   53.00%   52.99%   -0.02%     
==========================================
  Files         877      877              
  Lines       62128    62131       +3     
  Branches    11332    11333       +1     
==========================================
- Hits        32934    32928       -6     
- Misses      26533    26537       +4     
- Partials     2661     2666       +5
Flag Coverage Δ
#production 40.96% <0.00%> (-0.02%) ⬇️
#tests 94.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gerhardol gerhardol mentioned this pull request Sep 13, 2020
Open
gerhardol
gerhardol reviewed Sep 13, 2020
View reviewed changes
Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is fine (much easier to use than (CTRL+Shift+B), but I would like to sync with the discussion in #8452 (maybe #8414 too).

@RussKie
Copy link
Member Author

RussKie commented Sep 13, 2020 via email

@gerhardol
Copy link
Member

but I would like to sync with the discussion in #8452

Were you thinking of some other issue?

No - see my edit of the description too

@RussKie
Copy link
Member Author

RussKie commented Sep 13, 2020

but I would like to sync with the discussion in #8452

Were you thinking of some other issue?

No - see my edit of the description too

Sorry you've lost me. This is #8452.
I think #8441 is relevant to this proposal though.

@RussKie RussKie marked this pull request as draft September 13, 2020 10:16
@ghost
Copy link

ghost commented Sep 13, 2020

ALT+Left Click is bette than CTRL+Shift+B.

Because Left Click used for selecting, CTRL+B for creating new branch.
CTRL+Shift+B breaks the general logic.

@RussKie
Copy link
Member Author

RussKie commented Sep 13, 2020

Aye, I could never remember this shortcut and found it awkward to invoke too.

@gerhardol
Copy link
Member

but I would like to sync with the discussion in #8452

Were you thinking of some other issue?

No - see my edit of the description too

Sorry you've lost me. This is #8452.
I think #8441 is relevant to this proposal though.

Correct...

@GintasS
Copy link
Collaborator

GintasS commented Aug 6, 2021

This is an old PR and should be closed. @RussKie

@RussKie
Copy link
Member Author

RussKie commented Aug 6, 2021

No, this is a draft. It is still on agenda.

mstv
mstv reviewed Jan 27, 2022
View reviewed changes
Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Though ToggleHighlightSelectedBranch is misleading and should be renamed to HighlightSelectedBranch.

Alt+Click, should be prepended to the ShortCutString of the item in the View menu.

@RussKie RussKie mentioned this pull request Jul 25, 2022
Merged
@gerhardol gerhardol marked this pull request as ready for review July 25, 2022 20:13
@gerhardol
Copy link
Member

gerhardol commented Jul 25, 2022 •
edited

Rebased, applied review comments.
Made Alt-LButton independent of other modifiers, Ctrl-Alt-Click will both add to selection and Highlight branch.

image

@RussKie @gerhardol
Allow highlight branch by Alt+Click in the grid
15d6ca6 
Expose the same behavior as "Highlight selected branch" in the revision
grid via Alt+Left Click.
@gerhardol gerhardol requested a review from mstv July 27, 2022 20:31
@RussKie
Copy link
Member Author

RussKie commented Jul 28, 2022

You're happy with it - please merge it. Or at least approve it :)

@RussKie RussKie added this to the 4.0.0 milestone Jul 28, 2022
@gerhardol gerhardol merged commit 8eae96e into gitextensions:master Jul 28, 2022
@ghost ghost removed this from the 4.0.0 milestone Jul 28, 2022
@ghost ghost added this to the vNext milestone Jul 28, 2022
gerhardol pushed a commit that referenced this pull request Jul 28, 2022
@RussKie @gerhardol
Allow highlight branch by Alt+Click in the grid (#8452)
d46d8cc 
Expose the same behavior as "Highlight selected branch" in the revision
grid via Alt+Left Click.

Co-authored-by: Gerhard Olsson <gerhardol@users.noreply.github.com>
(cherry picked from commit 8eae96e)
@gerhardol gerhardol modified the milestones: vNext, 4.0.0 Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerhardol gerhardol gerhardol approved these changes

@mstv mstv Awaiting requested review from mstv

Assignees

@RussKie RussKie

Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RussKie @gerhardol @GintasS @mstv