Dialogs layout alignment - FormCreateBranch

[RussKie]

Relates to #6183

Screenshots

• Before:
  

• After
  

❗ Please note "Help" button will be removed in the follow up PRs to reduce the wasted space at the bottom.

---

✒️ I contribute this code under The Developer Certificate of Origin.

[RussKie]

@NikolayXHD need your help here - the colour of "Clear working directory and index" checkbox is too dark with the new colours. Is this something we're calculating dynamically?

[codecov]

Codecov Report

Merging #8490 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8490      +/-   ##
==========================================
- Coverage   55.06%   55.06%   -0.01%     
==========================================
  Files         901      901              
  Lines       65047    65050       +3     
  Branches    11726    11726              
==========================================
- Hits        35818    35817       -1     
- Misses      26473    26475       +2     
- Partials     2756     2758       +2     

Flag	Coverage Δ
#production	41.99% <100.00%> (-0.01%)	⬇️
#tests	94.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[NikolayXHD]

@NikolayXHD need your help here - the colour of "Clear working directory and index" checkbox is too dark with the new colours. Is this something we're calculating dynamically?

From what I can see by debugging, the color for disabled text is calculated dynamically by WinForms

https://source.dot.net/#System.Windows.Forms/System/Windows/Forms/ButtonInternal/ButtonBaseAdapter.cs,675

Like the code above shows, if the background does not have magic value SystemColors.Control, the disabled text color will be calculated by making background color darker, regardless of whether the background is bright or dark, which produces near-black text color on dark gray background

[NikolayXHD]

A proper workaround would be something like

// GitExtensionsDialog.cs
if (ColorHelper.IsDarkTheme())
  this.MainPanel.BackgroundColor = SystemColors.Control;

[mstv]

I don't like the large borders in the newly aligned dialogs. The dialogs cover too much of the main window without reason.

[RussKie]

From what I can see by debugging, the color for disabled text is calculated dynamically by WinForms

source.dot.net/#System.Windows.Forms/System/Windows/Forms/ButtonInternal/ButtonBaseAdapter.cs,675

Like the code above shows, if the background does not have magic value SystemColors.Control, the disabled text color will be calculated by making background color darker, regardless of whether the background is bright or dark, which produces near-black text color on dark gray background

@NikolayXHD omg 😱 wow

@merriemcgaw @JeremyKuhne we have work to do 😉

[RussKie]

Scratch that, the discussion is in #6183.