Fix JumpList being created too soon #8499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #8499 +/- ##
==========================================
+ Coverage 54.75% 54.80% +0.05%
==========================================
Files 898 898
Lines 64251 64255 +4
Branches 11440 11478 +38
==========================================
+ Hits 35179 35218 +39
+ Misses 26390 26333 -57
- Partials 2682 2704 +22
Flags with carried forward coverage won't be shown. Click here to find out more. |
Currently, at least on some systems, there is no process-level main
window yet when FormBrowse is loaded, so the creation of the JumpList
fails ("A valid active Window is needed").
So we wait for the OnActivated(), where this seems to be always OK.
We also need to keep track of any call to AddToRecent() it it happened
before actual JumpList creation.
Fixes gitextensions#8421
lanfeust69
force-pushed
the
fix_jumplist
branch
from
81430ee
to
c91a780
Compare
Indeed, I created the PR through GitExtensions itself, and it didn't use the template 🙂 Note that the "Fixes" part was already in the commit message, though. |
RussKie
approved these changes
Oct 2, 2020
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8421
✒️ I contribute this code under The Developer Certificate of Origin.