Update layout

[RussKie]

Relates to #6183

Resolves #8521

Proposed changes

• Reduce margins and paddings by at least 12px in each dimension
  • Update FormClone
  • Update FormInit
  • Update FormStatus
• Fix Accept and Cancel buttons that get unset by adding buttons to the controls panel.

Screenshots

Before	After
..
..

---

✒️ I contribute this code under The Developer Certificate of Origin.

[codecov]

Codecov Report

Merging #8510 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8510      +/-   ##
==========================================
- Coverage   55.05%   55.05%   -0.01%     
==========================================
  Files         901      901              
  Lines       65043    65047       +4     
  Branches    11726    11726              
==========================================
+ Hits        35811    35813       +2     
+ Misses      26475    26473       -2     
- Partials     2757     2761       +4     

Flag	Coverage Δ
#production	41.99% <100.00%> (+<0.01%)	⬆️
#tests	94.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[gerhardol]

Looks better - I want smaller margins (discussed in the issue) but I will not make it better myself

[mstv]

I would right-align the bottom buttons with the boxes in the client area.

[ghost]

[RussKie]

Yes, 18 is the new reduced padding. The middle between 12 and 24. Changing layouts of the forms is outside the scope of this PR.

[ghost]

Yes, 18 is the new reduced padding. The middle between 12 and 24.

Red color shows indents that do not correspond to the declared 18px.
Other colors indicate areas for possible improvement.

[ghost]

Change paddings for base ControlsPanel.
ivangrek@1989c24

[ghost]

For such indents, the button looks better than 32px. For comparison.

[RussKie]

Change paddings for base ControlsPanel.
ivangrek@1989c24

Thank you, but you have probably missed my reply in #6183 (comment).
The spacing in the controls panel is (almost) aligned with the Task Dialog. Increasing the vertical paddings to 18px makes it look odd, and won't go well with either Gerhard or Michael.

[ghost]

I would then recommend using harmonic values ​​for derived margins: 1:1, 1:2, 1:3, 1:4.
This is also an argument for 12px.

[RussKie]

Windows itself is inconsistent (haha!), but it generally doesn't have the same value for v- and h-padding for buttons - the TD is a perfect example of this.

There's another aspect to this - buttons placed at the bottom panel invoke actions that apply to the whole dialog, whilst there may be other action elements that don't. To make this fact more obvious, and for a consistent UX this panel is visually separated from the main content. However the buttons aren't meant to dominate visually and steal user's focus from the main content.
There's a whole science around UX, useability and "comfortable" spacing (which I'm not sufficiently equipped to have deep discussions about), but I based on my experience and observations giving buttons as much v-padding makes the bottom more prominent that necessary, and thus divert some of the user's attention from the task at hand.

On the other hand, if the main content h-paddings are too small - it makes a dialog visually unpleasant. And hence the recommendations for 12/24 paddings.
Since a lot of our form are resizable, and generally larger than 640px, making h-paddings 12px doesn't feel like a good UX. Dynamically re-calc paddings feels even worse decision. And since 24px is regarded by few members of the team as "too wide", 18 feels like a good middle ground.

[ghost]

I thought these tasks were aimed at developing a common approach. And so ok.

[gerhardol]

On the other hand, if the main content h-paddings are too small - it makes a dialog visually unpleasant. And hence the recommendations for 12/24 paddings.
Since a lot of our form are resizable, and generally larger than 640px, making h-paddings 12px doesn't feel like a good UX.

This is where we disagre - I do not find 12 unpleasant for large windows

Dynamically re-calc paddings feels even worse decision.

yes...

And since 24px is regarded by few members of the team as "too wide", 18 feels like a good middle ground.

But the recommendation is to have multiple by 4, 18 may scale worse

[RussKie]

@msftbot merge in 24 hours

[ghost]

Hello @RussKie!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

• I won't merge this pull request until after the UTC date Tue, 20 Oct 2020 12:53:42 GMT, which is in 1 day

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

[RussKie]

Margins are 12px now