updated removeFiles to use GetBatchOutput and added unit tests

[BrianFreemanAtlanta]

Fixes #8404 (Remove Files generates FileName or extension too long)

Proposed changes

• Updated GitModule.RemoveFiles to use GetBatchOutput with BuildBatchArgumentsForFiles

Test methodology

• Added unit test for empty file list
• Added unit test for 2 files in the list

Test environment(s)

• GIT 2.8
• Windows 10

---

✒️ I contribute this code under The Developer Certificate of Origin.

[codecov]

Codecov Report

Merging #8527 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8527      +/-   ##
==========================================
+ Coverage   55.07%   55.11%   +0.03%     
==========================================
  Files         899      899              
  Lines       64705    64748      +43     
  Branches    11624    11627       +3     
==========================================
+ Hits        35635    35683      +48     
+ Misses      26337    26333       -4     
+ Partials     2733     2732       -1     

Flag	Coverage Δ
#production	42.02% <100.00%> (+0.04%)	⬆️
#tests	94.80% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[RussKie]

👍 LGTM

[RussKie]

[nit] incorrect indentation

[RussKie]

Please provide your signoff in contributors.txt

Thank you

[mstv]

As recently recommended in order to squash (after merging), you could:

• select the head of your branch
• create a copy of your branch Create new branch here with unchecked Checkout after create in order to have a copy for comparison (I know, this is not really necessary when showing rev-log commits.)
• select the head of the master branch
• Reset current branch to here with the default mode Mixed
• stage and commit again
• compare the with the copy branch created above by selecting them both (Ctrl+Left MB click)
  Your changes should be listed in the group Common Diff with BASE. The other groups should be empty.
• force-push

[pmiossec]

* `Reset current branch to here` with the default mode `Mixed`

I would just change that by doing:

• Reset current branch to here with the default mode Soft (that kept the changes already in the staging aréa so no need to stage the changes again)

[RussKie]

I added a wiki: https://github.com/gitextensions/gitextensions/wiki/How-To:-Squash-and-Rebase-your-changes

@mstv @pmiossec feel free to add and/or update it as you see necessary. Thank you

[RussKie]

@BrianFreemanAtlanta please keep only the commit with your changes pertaining to the fix. If you send your signoff to the contributors.txt as a separate PR it will make merging both of your PRs simpler.

Thank you.

[RussKie]

Thank you