Fix #8188: cannot force push tags

[lhiginbotham]

Fix #8188: cannot force push tags

• Checking the "force push" option in the tags tab of the push form resulted in passing ForcePushOptions.ForceWithLease to the git push command builder
• Add a check for the force push checkbox for the tags tab in order to pass the correct ForcePushOptions.Force value to the command builder

Test methodology

• I've tested this out with a dummy remote repo on GitHub and verified that I am now able to force push a tag from one commit to another

Test environment(s)

• GIT 2.28.0.windows.1
• Windows 10

---

✒️ I contribute this code under The Developer Certificate of Origin.

[codecov]

Codecov Report

Merging #8529 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8529      +/-   ##
==========================================
+ Coverage   54.99%   55.11%   +0.12%     
==========================================
  Files         902      903       +1     
  Lines       65170    65222      +52     
  Branches    11751    11752       +1     
==========================================
+ Hits        35841    35950     +109     
+ Misses      26555    26490      -65     
- Partials     2774     2782       +8     

Flag	Coverage Δ
#production	42.06% <100.00%> (+0.12%)	⬆️
#tests	94.83% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[vbjay]

Force push with lease is there to prevent code stomps. If you want to make it work. Do a fetch all and review history and make sure you are ok with overwriting stuff. Rebase as needed and then push.

[RussKie]

Force push with lease is there to prevent code stomps.

You can't push tags with lease.

[RussKie]

👍
Can you please add a test for GetForcePushOption as well?

[vbjay]

Got it. Tags vs commits.

[lhiginbotham]

@RussKie

Can you please add a test for GetForcePushOption as well?

I am not sure how I would go about adding a test for this method: 1) it is a private method of GitUI.CommandsDialogs.FormPush and 2) there do not appear to be any tests for the FormPush class that I can see... Are you suggesting I write some tests that somehow execute the form for the various possible "force push" button states and then somehow check what git command was generated? Otherwise, I can change the code to expose GetForcePushOption() as a public static method of FormPush, taking in the three button states as parameters and then just simply test this new public method in a simple test suite.

[RussKie]

1. it is a private method of GitUI.CommandsDialogs.FormPush

We test non-public API with a help of TestAccessor struct. There are few examples, you can have a look at FormPull.TestAccessor, this would probably be the closest to what you'd need.

2. there do not appear to be any tests for the FormPush

Bummer! But we can fix this :)
I think you can pretty much copy FormPullTest class, remove all but one test that would toggle checkboxes and assert that form.GetTestAccessor().GetForcePushOption() returns the expected.

This should be fairly straight forward, but holler if you get stuck.
Thank you

[lhiginbotham]

@RussKie
Done! I hope this is what you were looking for in terms of tests.

[RussKie]

👍

[RussKie]

Please squash and it is ready to go.

[lhiginbotham]

@RussKie this is good to be merged, thanks!

[RussKie]

Thank you